What android phones do you recommend and why?

You could install LineageOS on your existing phone instead of upgrading. The OnePlus 7 Pro is supported. The install process can be daunting depending on your technical skills, but it's a one-time process since the phone gets updates over-the-air after the OS is installed.
I did this with my OnePlus 6 a few months ago and the experience has been good. Switching to LineageOS bumped Android to version 13, whereas it was stuck on Android 11 on stock OnePlus firmware. I'm getting regular updates again, including open-source Android security patches. Not everything gets patched though, some of the core firmware is proprietary to OnePlus and that cannot be patched by anyone but them. It's letting me extend the life of a phone still works well and has a 3.5mm headphone jack.
- Really seconding this. A lot of guides are also available with videos and OnePlus is notorious for being easy to unlock and flash. The op7pro is still a good device and if you have kept it till now you might as well give it a breath of fresh life by installing a new Android version.
  
  OnePlus is notorious for being easy to unlock and flash
  Were. OnePlus has settled.
- If one is okay with rooting and can get a (non Verizon) Google pixel, graphene OS is for the OCD fanatics, and CalyxOS is a more featured runner up. Both are only on pixels largely for the re-lockable boot loader.
  lineage is also a good rom, and they support way more devices
  
  Graphene is only on pixels but calyx supports at least a few more models including fairphones.
- I might go this route; thank you!!
  
  Decent details here:
  https://odysee.com/@AlphaNerd:8/how-to-install-lineage-os-to-oneplus-7

A lot of people won't like this answer, but I would not recommend anything from Samsung. Yes, the hardware on paper is typically excellent. However, everything else that comes with the experience is a complete joke to me.
The bootloader is locked, and even if you manage to get it unlocked Knox will be permanently tripped.
I never personally liked OneUI, but accepted it as long as it works. Unfortunately that's also not been the experience for me.
The last update they pushed for my phone broke Bluetooth connectivity, and it'll never be fixed, because they said there won't be any updates period. Now I'm left with a pen notification that never goes away, and a watch that disconnects every 15 minutes.
Their own stock apps are not very convenient at all, but don't forget to remind you to sign up for their updated data theft EULA every time you open them
And that's just software. It doesn't stop there. On my Note 10, the glass back completely peeled off, because of internal heat, and the only thing holding it together is the case. Keep in mind that this is from just regular usage. I don't play games on my phone, or do anything else that would warrant this kind of output
- Interesting... I switched away from Samsung and actually hated stock Android!
  I actually preferred One UI to the standard pixel, mainly because Google ruined the quick settings - they made each button unnecessarily big, and turning on/off the wifi requires two taps instead of one now (Internet > Wifi). That's something I can't change without rooting.
  Some Samsung stock apps are actually a great alternative to the android ones (I use Samsung Notes a ton). The only downside is they force you to download it through their own app store.
  Samsung doesn't really have much bloat now, and the few pieces of bloat i found could be uninstalled
  Samsung is still the only phone manufacturer with triple camera setups in a small flagship phone
  Don't get me wrong, it's not perfect, but the issues I had with Samsung were solvable (e.g. uninstalling bloat is a one-time thing) while the annoyances I've had with a Pixel aren't solvable (quick settings, no third camera).
  
  It all comes down to personal preferences and experiences, so I'm glad you had a good time
- None of the issues I've described have any relationship with the launcher
- I agree completely. I LOVED the first 3-5 Galaxy S phones, but they just kept adding more bloat.
  I'm on year 5 with my Pixel 3, and when it finally craps out, I'm going with another Pixel.
  
  I loved my pixel 2, but hate my pixel 6. I'm switching away from pixel as soon as this one dies
- I broke my One Plus 7 Pro and now have a Galaxy S21 Ultra, and while I don't hate it, I don't think I'll be getting another samsung
  However, I will say, Samsung keyboard is legitimately the best Andorid keyboard overal. I'll probably be installing it onto my next phone. But, like, it's sad that that's the only nice thing I can say about it.
  It's not a bad phone, and I bought it used, but Samsung is just so bloaty. I'd much rather a stock experience than their software
  
  Wow. I absolutely detest the Samsung keyboard. It's absolutely removed on terms of prediction and button accuracy.
  Gboard, while not great, seems to be the best/most accurate. I don't like Gboard, don't get me wrong, but it's way more accurate than Samsung

Used pixel, install grapheneos
used because it's better environmentally than buying new
grapheneos because it's more secure and private than stock android
- I do something the same, I buy last gen or gen before phones used on Swappa and then install Lineage OS so I can have a stable, updated, and efficient phone.
  I would say about 9h of screen on time for a Pixel 5 on its original OEM battery is not to bad.
- I have had a pixel 5 and 6 and both died within 2 years. They would both hard crash and shut off for a bit and eventually stop powering up altogether. I never had that issue with other brands. I ended going back to samsung with an S23 and it works fine for now.
- Why not Lineage os or /e/ os?
  
  They have different goals. I use /e/, where the focus is removing all communication with Google while providing an OS that's as user friendly and ready to use as the competition.
  
  Those are't as secure. If you look around there are comparisons of them that go into the details

What about the newest fairphone which is being released this fall, not thc best for your bucks, but built a bit more ethically than the others, and a modular design enabling eeasy repair*
I don't have one, but heard good stuff about the 4 and consider getting the 5 as my 5 year old Huawei is aging
- I have the 4 and I relly like it. It can't compete performance wise with other phones at the same price point, but the mission is great and you get a long life out of it and good software support.
  I am running iodeOS right now and it is just great, couldn't be happier. I am however not running games on it or anything, so not the biggest power user here...
  
  I have it, like it. Works well but no headphone jack is kinda weird. My screen does have a ghost input issue though which is very common for these phones. Recent update kinda fixed it but yeah its a hardware issue mainly so that sucks.
- People get stuck on the repairability bit, but the two times I had to make candybar repairs I was able to do so regardless. The Fairphone is hyped up, but I'm in the market for flagship spec and I absolutely must have a headphone jack, so it doesn't suit me.
  
  Same boat here, headphone jack is nonnegotiable.

Non- phone carrier variants of Google Pixels because of Grapheme OS. The crap that Verizon pumps out blocks the boot loader to be unlocked, but the ones google and amazon sells can do OEM boot loader unlocks.
Edit: also want to point out, pixels usually get the most updates out of all androids. So long as its in the support window, google will update drivers and kernels for it.
- I'll third this. Main thing I miss is Tap-to-Pay, but it's not that hard to carry a card. Some people miss Android Auto, but I've never used it.
  So I'll trade some very minor conveniences for increased security and privacy.
- The people behind GrapheneOS even extend the support. Currently rocking Android 14 with GrapheneOS on my Pixel 4a.
  
  How? I have an 4a and it's on Android 13 and won't update.

The Pixel is the best you're going to do in 2023.